Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shop #137

Merged
merged 15 commits into from
Dec 21, 2024
Merged

Shop #137

merged 15 commits into from
Dec 21, 2024

Conversation

JonaLam
Copy link
Collaborator

@JonaLam JonaLam commented Nov 5, 2024

Description

Added a shop system
new shop scene which sells item

Related issue(s)

#119

List of changes

  • Changed the shop scene into something.
  • Added shop item class which we place in the scene to sell the diffrent items

Additional notes

How items are priced is not implemented in any meaningful way other than a set number on each of the shop items
the pool of items the shop can sell is just strings to their position in the files
The inventory might make you unable to click anything, to fix you can make the inventory be a child of the inventorynode rather than the tree

@Turtyo Turtyo linked an issue Nov 5, 2024 that may be closed by this pull request
@Turtyo
Copy link
Collaborator

Turtyo commented Nov 5, 2024

I think we should remove the test on the naming convention, it's more bothersome than anything else

Copy link
Collaborator

@Turtyo Turtyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the scene inside the game, the overlay on the top right is not correctly on screen. The proceed button should automatically open the map, or the map movement should be set to allowed directly when entering the shop (I think the second option is better)

Opening the inventory still prevents it from interacting with anything else or being closed, as mentioned in #136
That makes it impossible for me to add gold and thus to test that buying things in the shop actually work, how did you test that btw ?

#Scenes/Events/shop/0.t1104.tmp Outdated Show resolved Hide resolved
Managers/ShopManager.gd Outdated Show resolved Hide resolved
Cards/CardWorld.gd Show resolved Hide resolved
Managers/ShopManager.gd Show resolved Hide resolved
Shop/shop_item_consumable.gd Outdated Show resolved Hide resolved
Shop/ShopItemCard.gd Outdated Show resolved Hide resolved
Shop/shop_item_relic.gd Outdated Show resolved Hide resolved
Shop/shop_item_torch.gd Show resolved Hide resolved
Shop/shop_item_torch.gd Outdated Show resolved Hide resolved
#Scenes/Events/shop/CardRemoval.gd Outdated Show resolved Hide resolved
@Tysterman74
Copy link
Collaborator

Also, if we're removing out items and consumables should we have this PR updated to remove those sections?

Tysterman74
Tysterman74 previously approved these changes Dec 10, 2024
@Turtyo
Copy link
Collaborator

Turtyo commented Dec 14, 2024

Yes, since we won't be using items and consumables, I would comment out / disable the items in this PR; the shop is still useful to buy torches and cards

Copy link
Collaborator

@Turtyo Turtyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
The overlay is not positioned correctly.

The proceed button doesn't open the map.

@JonaLam
Copy link
Collaborator Author

JonaLam commented Dec 19, 2024

I removed the items and consumables from the shop, they're just not there, but I don't really see the point of deleting the files so I think it's fine to let them be there.

I also removed the proceed button and made it so you can move by opening the map.

Turtyo
Turtyo previously approved these changes Dec 21, 2024
@Turtyo Turtyo merged commit fca8bb6 into Saplings-Projects:main Dec 21, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shop event
3 participants