-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shop #137
Shop #137
Conversation
I think we should remove the test on the naming convention, it's more bothersome than anything else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking the scene inside the game, the overlay on the top right is not correctly on screen. The proceed
button should automatically open the map, or the map movement should be set to allowed directly when entering the shop (I think the second option is better)
Opening the inventory still prevents it from interacting with anything else or being closed, as mentioned in #136
That makes it impossible for me to add gold and thus to test that buying things in the shop actually work, how did you test that btw ?
Also, if we're removing out items and consumables should we have this PR updated to remove those sections? |
Yes, since we won't be using items and consumables, I would comment out / disable the items in this PR; the shop is still useful to buy torches and cards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the items and consumables from the shop, they're just not there, but I don't really see the point of deleting the files so I think it's fine to let them be there. I also removed the proceed button and made it so you can move by opening the map. |
Description
Added a shop system
new shop scene which sells item
Related issue(s)
#119
List of changes
Additional notes
How items are priced is not implemented in any meaningful way other than a set number on each of the shop items
the pool of items the shop can sell is just strings to their position in the files
The inventory might make you unable to click anything, to fix you can make the inventory be a child of the inventorynode rather than the tree